This repository has been archived by the owner on Aug 16, 2024. It is now read-only.
fix: consolidate Navigation and navigation
#43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fibble
approved these changes
Jan 31, 2024
fibble
approved these changes
Jan 31, 2024
sanakhandvsa
pushed a commit
that referenced
this pull request
Jan 31, 2024
sanakhandvsa
added a commit
that referenced
this pull request
Feb 2, 2024
This reverts commit 0d7ab9f.
jerotire
pushed a commit
to dvsa/vol-app
that referenced
this pull request
Aug 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The projects were using a mix of
Navigationandnavigationresulting in two different objects - this caused issues with navigation as two different objects were being mutated and used.I went with
navigationeven though it was a larger refactor due to that being the alias that is registered in the upstream package: https://github.com/laminas/laminas-navigation/blob/2f39ab2f929d23da89bbb4401efdccb6e72eaf68/src/ConfigProvider.php#L33.Related issue: https://dvsa.atlassian.net/browse/VOL-4900 & https://dvsa.atlassian.net/browse/VOL-4915
Before submitting (or marking as "ready for review")